Used vendored base64 encoding implementation rather than Foundation.Data #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Jan 11, 2022
|
Hey @fabianfett, mind taking a look at this when you get time? Thanks! |
fabianfett
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Sorry for taking so long to review. The code change looks good. @Lukasa how do we deal with adding a Note to the Notice file, as the original repo does not exist anymore?
|
Copy the note from NIO. |
|
@karwa Do you mind copying the note from NIO's NOTICE file? |
|
@fabianfett done |
fabianfett
approved these changes
Jan 21, 2022
|
Failing nightly-main and nightly-5.6 API because of missing Sendable requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses @fabianfett's base64 implementation rather than Foundation. Apparently it's faster, and it avoids copying the string to a Foundation.Data object before encoding.
Single-file version copied from https://github.com/apple/swift-nio/blob/main/Sources/NIOWebSocket/Base64.swift
I disabled swiftformat on the file so that, other than the copyright header and swiftformat comment, it remains identical to the version in NIO. Alternatively, we could add a package dependency rather than copying the file. Up to you guys.
With this and #534, the only remaining Foundation dependencies will be
URL, and the couple of convenience APIs in theFoundationExtensionsfile. If they're both accepted, I can go through and replace all occurrences ofimport Foundationwithimport struct Foundation.URLin a follow-up.There are already tests for this API, so I didn't feel it necessary to add any.